Upgraded sample app #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@darrenchann could you please perform first round of review, thanks. |
|
Tried running project going through repro steps: (tested rerunning project/rebuilding project on master branch with no issues) |
|
@darrenchann is that from this repo or the main React Native repo? the settings.gradle file looks different |
Let me review my project structure, it's not looking correct on my end |
|
iOS: android: now able to get both platforms up |
darrenchann
approved these changes
Aug 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NSDK-168
Overview:
This PR replaces the sample app with a more comprehensive app in order to better demonstrate how the wrapper can be embedded in an existing app and how its API can be used.
The app is a simple file manager within the app's folder with the ability to add files from the device's local storage or from the web, plus other miscellaneous functionalities. It uses this package for opening PDF files and for converting Office files to PDF.
The app is built using Expo SDK 46 with bare workflow (ejected) and React Native version 0.69.4.
Testing:
node_modules, and runyarn installyarn iosyarn android